Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple conversion in draw_text_on_image function, improve test_image_translator ,and add tests for image_utils.py #52

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

skytin1004
Copy link
Collaborator

@skytin1004 skytin1004 commented Oct 25, 2024

Purpose

Description

  1. The draw_text_on_image function had a bug where the size of the text was incorrectly handled as a list instead of a tuple. This has been corrected to ensure proper functionality.
  2. Several improvements were made to the test cases for test_image_translator to ensure proper testing of bounding box extraction and image translation.
  3. Added tests for image_utils.py

Related Issue

#15

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

  • Yes
  • No

Type of change

  • Bugfix
  • Feature
  • Code style update (e.g., formatting, local variables)
  • Refactoring (no functional or API changes)
  • Documentation content changes
  • Other... Please describe:

Checklist

Before submitting your pull request, please confirm the following:

  • I have thoroughly tested my changes: I confirm that I have run the code and manually tested all affected areas.
  • All existing tests pass: I have run all tests and confirmed that nothing is broken.
  • I have added new tests (if applicable): I have written tests that cover the new functionality introduced by my code changes.
  • I have followed the Co-op Translators coding conventions: My code adheres to the style guide and coding conventions outlined in the repository.
  • I have documented my changes (if applicable): I have updated the documentation to reflect the changes where necessary.

Additional context

@skytin1004 skytin1004 self-assigned this Oct 25, 2024
@github-actions github-actions bot added core Related to any changes in core source files tests labels Oct 25, 2024
@skytin1004 skytin1004 added bug Something isn't working enhancement New feature or request tests and removed tests enhancement New feature or request labels Oct 25, 2024
@skytin1004
Copy link
Collaborator Author

I have reviewed the changes and everything looks good.

@skytin1004 skytin1004 merged commit d2a3fae into Azure:main Oct 25, 2024
5 checks passed
@skytin1004 skytin1004 deleted the test branch October 29, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Related to any changes in core source files tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant