Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing old crds and nodeTemplate reference #120

Closed
wants to merge 2 commits into from

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
Removed old crds and nodeclass

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@Bryce-Soghigian
Copy link
Collaborator Author

Wondering if we need these old crds, I assume they were kept in for kaito since kaito uses alpha apis? Opened this pr to have that discussion

CC: @rakechill

@coveralls
Copy link

coveralls commented Jan 28, 2024

Pull Request Test Coverage Report for Build 7683801106

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.626%

Totals Coverage Status
Change from base Build 7680713204: 0.0%
Covered Lines: 35605
Relevant Lines: 36471

💛 - Coveralls

@tallaxes
Copy link
Collaborator

Wondering if we need these old crds, I assume they were kept in for kaito since kaito uses alpha apis?

No, these CRDs are still required by the currently used version of core; so this will have to wait until we update core to v0.33+ (very soon). They are brought automatically from core within make verify (try make presubmit), so just deleting them from repo is ineffectual. (If you are wondering why this does not get caught by "file modifications detected" check - git diff does not consider new/untracked files ...) When these do go away, the corresponding symlinks from the chart need to go too.

nodeTemplate variable - good catch!

@Bryce-Soghigian
Copy link
Collaborator Author

Thanks @tallaxes will open new pr

@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/removing-old-crds branch February 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants