Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: output of grep command is capital letter and AZURE_ACR_NAME should be unique #223

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

jacobbaek
Copy link
Contributor

  • changed to False from false.
  • can make a unique AZURE_ACR_NAME

Fixes #

Description
'az group exists' printed true/false as capital letter.
So i added the ignore-case option(-i).
Also AZURE_ACR_NAME should be unique. but if the codespace is not using, only set karpenter as the AZURE_ACR_NAME

How was this change tested?
make az-all

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note
NONE


* changed False from false. 
* can make a unique AZURE_ACR_NAME
@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8356808974

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.716%

Totals Coverage Status
Change from base Build 8353624370: 0.0%
Covered Lines: 35591
Relevant Lines: 36423

💛 - Coveralls

Makefile-az.mk Outdated Show resolved Hide resolved
@Bryce-Soghigian Bryce-Soghigian merged commit 675e8cd into Azure:main Mar 20, 2024
11 checks passed
@tallaxes
Copy link
Collaborator

@jacobbaek, thank you for the contribution!

  • I am curios which environment produced capitalized True/False? (Which I suspect is not valid JSON ...)
  • You can (and could) set AZURE_ACR_NAME prior to running make (it uses conditional assignment)

@tallaxes tallaxes added the area/devtools Issues or PRs related to devtools label Mar 20, 2024
@jacobbaek
Copy link
Contributor Author

Hi @tallaxes ,
In my case, the core.output setting was table. so the result of grep was printed "True".
It is not problem If use the json default setting.
To clarify, I also opened PR for updating document. there is 'az config set core.output=json'.
#225
Thanks for your advice.

@tallaxes
Copy link
Collaborator

In my case, the core.output setting was table. so the result of grep was printed "True".

Ok, that explains it. A better fix for that command would be to not rely on the default setting and have explicit -o json or -o tsv.

And thank you for helping document non-codespace dev environment!

@jacobbaek jacobbaek deleted the patch-1 branch March 22, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants