Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up schema registration #276

Merged
merged 6 commits into from
May 1, 2024
Merged

chore: clean up schema registration #276

merged 6 commits into from
May 1, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Apr 18, 2024

Description

Ensure init() blocks driving schema registration are in top-level drivers (operator and environments). The rationale is best captured in aws/karpenter-provider-aws#5086:

This PR moves the init statements that were present in the cloudprovider.go file to put them in the top-level operator.go file since all operator concepts rely on karpenter-core. This makes the dependencies required here clearer and serves as a paradigm that will be used going forward for declaring all base-level dependencies in operator.go files

This is already partially in place; this PR completes the move.

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added the area/code-organization Issues or PRs related to code organization label Apr 18, 2024
@tallaxes tallaxes self-assigned this Apr 18, 2024
@tallaxes tallaxes added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2024
@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 8904804242

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.774%

Totals Coverage Status
Change from base Build 8904783546: 0.0%
Covered Lines: 36281
Relevant Lines: 37107

💛 - Coveralls

@Bryce-Soghigian
Copy link
Collaborator

Can you help me understand a bit more why Chesterton placed the fence here?

@tallaxes
Copy link
Collaborator Author

Can you help me understand a bit more why Chesterton placed the fence here?

Please wait until the PR is out of Draft before reviewing

@tallaxes tallaxes marked this pull request as ready for review April 26, 2024 03:15
@tallaxes tallaxes merged commit 1f9d247 into main May 1, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/schema branch May 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-organization Issues or PRs related to code organization size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants