Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use untagged on ksnap acr purge #293

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Apr 23, 2024

Fixes #

Description

Don't use --untagged on ksnap acr purge, as it appears to be broken: Azure/acr-cli#131

How was this change tested?

  • Re-deployed (updated) ksnap; will watch the next run

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 9603097293

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.758%

Totals Coverage Status
Change from base Build 9602285705: 0.0%
Covered Lines: 36285
Relevant Lines: 37117

💛 - Coveralls

@tallaxes tallaxes self-assigned this Apr 26, 2024
@tallaxes tallaxes added kind/bug Categorizes issue or PR as related to a bug. area/artifacts Issues or PRs related to the hosting of release artifacts size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2024
@tallaxes tallaxes marked this pull request as ready for review April 26, 2024 03:32
var purgeOldArtifacts = '''
version: v1.1.0
steps:
- cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d --untagged
- cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will remove any image that is older than 30 days for snapshot images?

I also read about dry run we could use to test some of this if we wanted to add tests for this kind of thing.

--dry-run - Specifies that no data is deleted, but the output is the same as if the command is run without this flag. This parameter is useful for testing a purge command to make sure it does not inadvertently delete data you intend to preserve.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will remove any image that is older than 30 days for snapshot images?

Yes

--dry-run

Yes, though I'd prefer to check the results of the actual execution instead; don't quite trust --dry-run at this point

@tallaxes tallaxes merged commit 92425e7 into main Jun 20, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/acr-purge branch June 20, 2024 19:15
Bryce-Soghigian pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants