-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't use untagged on ksnap acr purge #293
Conversation
Pull Request Test Coverage Report for Build 9603097293Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
var purgeOldArtifacts = ''' | ||
version: v1.1.0 | ||
steps: | ||
- cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d --untagged | ||
- cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will remove any image that is older than 30 days for snapshot images?
I also read about dry run we could use to test some of this if we wanted to add tests for this kind of thing.
--dry-run - Specifies that no data is deleted, but the output is the same as if the command is run without this flag. This parameter is useful for testing a purge command to make sure it does not inadvertently delete data you intend to preserve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will remove any image that is older than 30 days for snapshot images?
Yes
--dry-run
Yes, though I'd prefer to check the results of the actual execution instead; don't quite trust --dry-run
at this point
Co-authored-by: Rachel Gregory <[email protected]>
Fixes #
Description
Don't use
--untagged
on ksnap acr purge, as it appears to be broken: Azure/acr-cli#131How was this change tested?
Does this change impact docs?
Release Note