Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): fix snapshot unset bash var bug #295

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

charliedmcb
Copy link
Collaborator

Fixes #294

Description
A bug was found with snapshot commands in the recent update for the release scripts:

How was this change tested?
Tested make snapshot and make az-all-user in a codespace
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@charliedmcb charliedmcb marked this pull request as ready for review April 23, 2024 17:50
@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 8804926456

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.736%

Totals Coverage Status
Change from base Build 8803956618: 0.01%
Covered Lines: 35662
Relevant Lines: 36488

💛 - Coveralls

@charliedmcb charliedmcb merged commit bb19747 into main Apr 23, 2024
10 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/fixSnapshotUnsetBashVarBug branch April 23, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.4.0-rc.3 running snapshot.sh gives an unbound variable error
3 participants