chore: Migrate to Go's native multierror handling #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Go supports handling multiple errors directly from version 1.20 onwards, this commit removes the need for an external library and instead uses native methods of multi-error handling. Signed-off-by: Feruzjon Muyassarov <[email protected]>
|
/test |
|
@Bryce-Soghigian I assume I don't have permission to trigger tests. Would you mind to help with triggering them? |
Pull Request Test Coverage Report for Build 9095892720Details
💛 - Coveralls |
|
ping @Bryce-Soghigian |
|
Upstream karpenter also uses multierr from uber. Until we see that move over I am thinking it best we stay consistent in the codebase. Closing for now, but thanks for raising the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # NA
Description
Now that Go supports handling multiple errors directly from version 1.20 onwards, this commit removes the need for an external library and instead uses native methods of multi-error handling.
How was this change tested?
Does this change impact docs?
Release Note