-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): add automated github releases for workflow #413
Conversation
Pull Request Test Coverage Report for Build 9587148810Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9588058498Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM (subject to testing). One concern: While there is value in aligning with AWS provider, marvinpinto/actions is no longer maintained. The author recommends semantic-release or action-gh-release. I wonder how hard it would be to move to one of those instead (maybe together with AWS provider)?
Good callout. I'll take a look over those other options and how they would align here. Can share over with |
Pull Request Test Coverage Report for Build 9604398468Details
💛 - Coveralls |
…b.com:Azure/karpenter into charliedmcb/automatedGithubReleasesInWorkflow
Pull Request Test Coverage Report for Build 9653958755Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9654039110Details
💛 - Coveralls |
@charliedmcb Do you think it would be more complex to understand this tool? From my perspective, additional feature sets that we don't use shouldn't impact us? And could potentially be more useful in the long term. Maybe I'm misunderstanding your reservations, though.
Does it seem like |
Yea, so I could see using it within the future. However, my main reservations are that while the tool does have extra features, it also seems to be build to handle releases in a way we aren't really looking to do atm. So, while it contains the tools we want, it also contains things that we'd want to strip away, and feels the added complexity might be excessive. Examples:
Things I'd like from it:
I so far also wasn't able to find an official github action for it, which means we'd have to make the action usage for it a bit extra complicated too. |
Good question. It also has a lot of open issues (more so even). Its hard to fully judge though. The |
Your responses make sense to me 👍 approving for now if you want to move forward with this! |
Switching to using semantic-release, so closing this PR |
Fixes #388
Description
We currently have to create the github release, and its release notes manually. This additional change makes the workflow automatically create the github release and generate the release notes.
This is modeled off aws:
However, since the repo
aws
is using is no longer maintained:I looked over the recommended substitutes, and found that I think the action-gh-release matches our current desires the best. Its closest to the old action. While the semantic-release action could be useful with some of its additional feature sets, I think for our current usage it goes above and beyond to a point we aren't currently looking for. This would require us to scope it down/not use it in the fully intended way.
This said the action-gh-release repo does have a lot of open issues. While its getting updates at what seem to be an ok cadence, and still maintained it seems like issues/fixes aren't being put through too frequently. That's my main reservation with it. Although, I still think its the correct choice for now.
This change also has some additional elements around automated pre-releases as that is something we have been currently doing, which is missing from the aws release.
How was this change tested?
Sadly there isn't a great way to test this until we are actually doing a release and running the workflow.
However, I did check the regex works correctly within bash. Although, not fully confirmed with the actual release variable.
*
Does this change impact docs?
Release Note