fix: properly garbage collecting orphaned network interfaces#642

Open

Bryce-Soghigian wants to merge 23 commits intomainfrom bsoghigian/network-interface-gc

+680-79

Commits on Jan 16, 2025

feat: adding ListNics to instanceprovider interface alongside a refactor of arg related functions to their own file
Bryce-Soghigian
committed
feat: adding garbage collection logic for network interfaces and refactoring gc functions slightly
Bryce-Soghigian
committed
feat: working poc of ARG Queries and nic garbage collection, need to fix tests
Bryce-Soghigian
committed
fix: tests failing due to ListVM
Bryce-Soghigian
committed
feat: split nic and vm into their own gc controllers, added shared state between them to prevent conflicts in nic deletion calls
Bryce-Soghigian
committed
feat: Add DeleteNic option to instance provider
Bryce-Soghigian
committed
docs(code-comment): adding clarification to unremovableNics
Bryce-Soghigian
committed
test: instanceprovider.ListNics barebones test and arg fake list nic impl
Bryce-Soghigian
committed
fix: bootstrap.sh
Bryce-Soghigian
committed
feat: adding in VM List into the networkinterface.garbagecollection controller to avoid attempts to delete nics that are managed by a vm
Bryce-Soghigian
committed
refactor: unremovableNics out of the vm gc controller in favor for a cleaner state list
Bryce-Soghigian
committed
fix:updating references to cache
Bryce-Soghigian
committed
Update pkg/controllers/nodeclaim/garbagecollection/nic_garbagecollection.go
Bryce-Soghigian
committed
test: adding composable network interface options to our test utils based on existing karp-core pattern
Bryce-Soghigian
committed
test: adding test we don't include unmanaged nics
Bryce-Soghigian
committed
test: adding network garbage collection suite and happy path
Bryce-Soghigian
committed
test: adding tests for unremovable nics
Bryce-Soghigian
committed
test: adding coverage that vm controller cleans up nics
Bryce-Soghigian
committed
refactor: renaming controller
Bryce-Soghigian
committed
fix: refactor name
Bryce-Soghigian
committed

Commits on Jan 17, 2025

Commits on Jan 19, 2025

fix: ci
Bryce-Soghigian
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: properly garbage collecting orphaned network interfaces#642

Commits on Jan 16, 2025

feat: adding ListNics to instanceprovider interface alongside a refactor of arg related functions to their own file

feat: adding garbage collection logic for network interfaces and refactoring gc functions slightly

feat: working poc of ARG Queries and nic garbage collection, need to fix tests

fix: tests failing due to ListVM

feat: split nic and vm into their own gc controllers, added shared state between them to prevent conflicts in nic deletion calls

feat: Add DeleteNic option to instance provider

docs(code-comment): adding clarification to unremovableNics

test: instanceprovider.ListNics barebones test and arg fake list nic impl

fix: bootstrap.sh

feat: adding in VM List into the networkinterface.garbagecollection controller to avoid attempts to delete nics that are managed by a vm

refactor: unremovableNics out of the vm gc controller in favor for a cleaner state list

fix:updating references to cache

Update pkg/controllers/nodeclaim/garbagecollection/nic_garbagecollection.go

test: adding composable network interface options to our test utils based on existing karp-core pattern

test: adding test we don't include unmanaged nics

test: adding network garbage collection suite and happy path

test: adding tests for unremovable nics

test: adding coverage that vm controller cleans up nics

refactor: renaming controller

fix: refactor name

Commits on Jan 17, 2025

refactor: using import directly

ci: checking error for controller

Commits on Jan 19, 2025

fix: ci