[Model] Implement model Unimp #83

yangcd-bupt · 2022-08-23T08:22:29Z

support ogbn dataset

Description

Checklist

Please feel free to remove inapplicable items for your PR.

The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage
Code is well-documented
To the best of my knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
Related issue is referred in this PR

Changes

support ogbn dataset

yangcd-bupt · 2022-08-25T07:02:24Z

get ogb node dataset via OgbNodeDataset class

Zhanghyi

增加一些测试代码，对于graph，link，node 各自选择一个最小的数据集写一下单元测试的代码放在 https://github.com/BUPT-GAMMA/GammaGL/tree/main/tests/datasets 下面

Zhanghyi · 2022-09-15T07:19:24Z

gammagl/datasets/ogb_graph.py

+import os.path as osp
+import numpy as np
+from gammagl.data import InMemoryDataset
+from gammgl.utils.ogb_url import decide_download, download_url, extract_zip


gammgl -> gammagl

Zhanghyi · 2022-09-15T07:49:46Z

gammagl/utils/ogb_url.py

@@ -0,0 +1,91 @@
+import urllib.request as ur


这个文件的代码替换为https://github.com/BUPT-GAMMA/GammaGL/blob/main/gammagl/data 里相应api的，例如https://github.com/BUPT-GAMMA/GammaGL/blob/main/gammagl/data/download.py

Zhanghyi · 2022-09-15T07:54:56Z

gammagl/datasets/ogb_graph.py

+
+            # check if previously-downloaded folder exists.
+            # If so, use that one.
+            if osp.exists(osp.join(root, self.dir_name + '_pyg')):


pyg相关的代码改成gammagl

dddg617 · 2022-09-20T08:53:22Z

tests/datasets/test_ogb_graph.py

+    print(data)
+    print(data[0])
+
+test()


Replace the function name "test" with "test_ogbgraphdataset", which makes it easier to distinguish the functions from other files.

dddg617 · 2022-09-20T08:53:40Z

tests/datasets/test_ogb_link.py

+    data=OgbLinkDataset('ogbl-ppa')
+    print(data[0])
+
+test()


dddg617 · 2022-09-20T08:53:45Z

tests/datasets/test_ogb_node.py

+    data=OgbNodeDataset('ogbn-arxiv')
+    print(data[0])
+
+test()


Zhanghyi · 2022-09-21T08:14:28Z

gammagl/datasets/ogb_node.py

+from gammagl.data import InMemoryDataset
+from gammagl.data.download import download_url
+from gammagl.data.extract import extract_zip
+from gammagl.io.read_ogb import read_node_label_hetero, read_graph, read_heterograph， read_nodesplitidx_split_hetero


中文逗号

dddg617 · 2022-09-21T09:17:42Z

tests/datasets/test_ogbgraphdataset.py

+    print(data)
+    print(data[0])
+
+test()


Replace the function name "test" with "test_ogbgraphdataset", which makes it easier to distinguish the functions from other files.

Using "assert" to check the correctness of some variable. e.g. the "feature.shape[0]" and "num_nodes" should be equal.

dddg617 · 2022-09-21T09:17:46Z

tests/datasets/test_ogblinkdataset.py

+    data=OgbLinkDataset('ogbl-ppa')
+    print(data[0])
+
+test()


dddg617 · 2022-09-21T09:17:53Z

tests/datasets/test_ogbnodedataset.py

+    data=OgbNodeDataset('ogbn-arxiv')
+    print(data[0])
+
+test()


dddg617 · 2022-10-27T12:42:15Z

examples/unimp/unimp_trainer.py

+        return loss
+
+
+class MultiHead(MessagePassing):


Put this section into gammagl.layers.conv.unimp_conv.py. If you put this into this file, users will not be able to use this function.

dddg617 · 2022-10-27T12:43:01Z

examples/unimp/unimp_trainer.py

+        return x
+
+
+class Unimp(tlx.nn.Module):


Put this section into gammagl.models.unimp.py. If you put this into this file, users will not be able to use this function.

dddg617 · 2022-10-28T03:38:14Z

gammagl/models/unimp.py

+        super(Unimp, self).__init__()
+
+        out_layer1=int(dataset.num_node_features/2)
+        self.layer1=MultiHead(dataset.num_node_features+1, out_layer1, 4,dataset[0].num_nodes)


I think users can choose their n_heads, so change this to let users choose their own n_heads instead of a fixed one.

dddg617 · 2022-10-28T03:38:21Z

gammagl/models/unimp.py

+        self.norm1=nn.LayerNorm(out_layer1)
+        self.relu1=nn.ReLU()
+
+        self.layer2=MultiHead(out_layer1, dataset.num_classes, 4,dataset[0].num_nodes)


dddg617 · 2022-10-28T03:53:57Z

gammagl/models/unimp.py

+import tlx.nn as nn
+from gammagl.layers import MultiHead
+
+class Unimp(tlx.nn.Module):


Please add rst doc here refer to this link: https://docs.qq.com/pdf/DUXRTTU9tUnB1WnFB.

dddg617 · 2022-10-28T04:02:28Z

examples/unimp/unimp_trainer.py

+        return loss
+
+
+    def forward(self, x, edge_index):


Why there are two forward functions?

dddg617 · 2022-11-07T01:52:37Z

gammagl/layers/conv/multi_head.py

+
+        alpha = self.dropout(segment_softmax(weight, node_dst, self.num_nodes))
+        x = tlx.gather(x, node_src) * tlx.expand_dims(alpha, -1)
+        return x


Is this function means Unimp? So what is the difference between this model and model GAT?

yangcd-bupt added 2 commits August 20, 2022 17:13

Create ogb_node.py

ac20c1a

support ogbn dataset

support ogb node dataset

d4ef822

yangcd-bupt added 7 commits August 30, 2022 16:59

extend InMemoryDataset

84a9fa2

do not rely on torch

ae6e395

update

21f6979

update

09321cf

support heterograph

bd694bc

support ogb graph dataset

ef7e5d0

support ogb link dataset

ec483a7

Zhanghyi reviewed Sep 15, 2022

View reviewed changes

yangcd-bupt added 6 commits September 15, 2022 19:27

add test file

f987fa4

del pyg

974f068

Update ogb_node.py

dafdd1b

change pyg to gammagl

f1aa221

do not use ogb_url

c0ddf81

Update read_ogb.py

6902fe7

dddg617 reviewed Sep 20, 2022

View reviewed changes

yangcd-bupt added 2 commits September 21, 2022 14:37

Update ogb_node.py

bc80112

update ogb_node

23d842e

Zhanghyi reviewed Sep 21, 2022

View reviewed changes

Update ogb_node.py

646dad4

dddg617 reviewed Sep 21, 2022

View reviewed changes

yangcd-bupt added 2 commits October 27, 2022 10:59

upload unimp

1c48b27

change function name

de1095e

dddg617 reviewed Oct 27, 2022

View reviewed changes

slipt unimp_trainer to three file

62c8e26

dddg617 reviewed Oct 28, 2022

View reviewed changes

dddg617 changed the title ~~Create ogb_node.py~~ [Model] Implement model Unimp Oct 28, 2022

dddg617 reviewed Oct 28, 2022

View reviewed changes

examples/unimp/unimp_trainer.py Outdated

return loss

def forward(self, x, edge_index):

Copy link

Contributor

dddg617 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are two forward functions?

yangcd-bupt added 2 commits October 28, 2022 13:48

fix bug

64fbefc

add doc

9a12bf4

dddg617 reviewed Nov 7, 2022

View reviewed changes

yangcd-bupt added 2 commits November 19, 2022 17:12

change multi-head

a8a2bc9

Update multi_head.py

9b2a3d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Model] Implement model Unimp #83

[Model] Implement model Unimp #83

yangcd-bupt commented Aug 23, 2022

yangcd-bupt commented Aug 25, 2022

Zhanghyi left a comment

Zhanghyi Sep 15, 2022

Zhanghyi Sep 15, 2022 •

edited

Loading

Zhanghyi Sep 15, 2022

dddg617 Sep 20, 2022

dddg617 Sep 20, 2022

dddg617 Sep 20, 2022

Zhanghyi Sep 21, 2022

dddg617 Sep 21, 2022

dddg617 Sep 21, 2022

dddg617 Sep 21, 2022

dddg617 Oct 27, 2022

dddg617 Oct 27, 2022

dddg617 Oct 28, 2022

dddg617 Oct 28, 2022

dddg617 Oct 28, 2022

dddg617 Oct 28, 2022

dddg617 Nov 7, 2022

[Model] Implement model Unimp #83

Are you sure you want to change the base?

[Model] Implement model Unimp #83

Conversation

yangcd-bupt commented Aug 23, 2022

Description

Checklist

Changes

yangcd-bupt commented Aug 25, 2022

Zhanghyi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhanghyi Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhanghyi Sep 15, 2022 •

edited

Loading