Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shift-JIS Error #170

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix Shift-JIS Error #170

merged 2 commits into from
Mar 19, 2024

Conversation

askdkc
Copy link
Contributor

@askdkc askdkc commented Mar 19, 2024

This will fix the issue #123

Closes #123

This will fix the issue Bacon#123
@askdkc askdkc mentioned this pull request Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@151a958). Click here to learn what that means.

Files Patch % Lines
src/Encoder/Encoder.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage        ?   63.28%           
  Complexity      ?      934           
=======================================
  Files           ?       47           
  Lines           ?     2974           
  Branches        ?        0           
=======================================
  Hits            ?     1882           
  Misses          ?     1092           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DASPRiD DASPRiD merged commit 735e04e into Bacon:main Mar 19, 2024
6 checks passed
@DASPRiD
Copy link
Member

DASPRiD commented Mar 19, 2024

Thanks a lot for your work, this will go out with the next release, just waiting for a few other PRs to get updated as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something wrong with appendKanjiBytes function?
3 participants