feat(helm): add securityContext and pull policy values to migration job #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krrishdholakia
pushed a commit
that referenced
this pull request
Jan 16, 2025
* feat(helm): add securityContext and pull policy values to migration job (#7652) * fix(helm): corrected indentation in migration-job.yaml * feat(helm): add securityContext and pull policy values to migration job * fix confusing save button label (#7778) * [integrations/lunary] Improve Lunary documentaiton (#7770) * update lunary doc * better title * tweaks * Update langchain.md * Update lunary_integration.md * Fix wrong URL for internal user invitation (#7762) * format * done * Update instructor tutorial (#7784) * Add in container structure tests for the nonroot image --------- Co-authored-by: Zackeus Bengtsson <[email protected]> Co-authored-by: yujonglee <[email protected]> Co-authored-by: Hugues Chocart <[email protected]> Co-authored-by: Nikolaiev Dmytro <[email protected]>
krrishdholakia
added a commit
that referenced
this pull request
Jan 16, 2025
* Add back in non root image fixes (#7781) * Add back in non root image fixes * Fix dockerfile * Fix perms * Add in container structure tests for the nonroot image (#7796) * feat(helm): add securityContext and pull policy values to migration job (#7652) * fix(helm): corrected indentation in migration-job.yaml * feat(helm): add securityContext and pull policy values to migration job * fix confusing save button label (#7778) * [integrations/lunary] Improve Lunary documentaiton (#7770) * update lunary doc * better title * tweaks * Update langchain.md * Update lunary_integration.md * Fix wrong URL for internal user invitation (#7762) * format * done * Update instructor tutorial (#7784) * Add in container structure tests for the nonroot image --------- Co-authored-by: Zackeus Bengtsson <[email protected]> Co-authored-by: yujonglee <[email protected]> Co-authored-by: Hugues Chocart <[email protected]> Co-authored-by: Nikolaiev Dmytro <[email protected]> --------- Co-authored-by: Rajat Vig <[email protected]> Co-authored-by: Zackeus Bengtsson <[email protected]> Co-authored-by: yujonglee <[email protected]> Co-authored-by: Hugues Chocart <[email protected]> Co-authored-by: Nikolaiev Dmytro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add chart variables for migration job security context and image
In environments where Pod Security Admission is set to
restrictive, and enforcement is enabled, the default security context policy of a pod will prevent it from running. The main pod deployment already allows for overriding the security context, this PR reuses the same security context settings for the migration job.Relevant issues
N/A
Type
🚄 Infrastructure
Changes
migrationJob.enabledvariable within job #7639[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
Tested deployment in restrictive environment where default security context otherwise would fail.