Houdini: Support multiple representations in batch publishing #6
Conversation
| files = eval_files_from_output_path( | ||
| output_path, | ||
| instance_data["frameStart"], | ||
| instance_data["frameEnd"]) |
There was a problem hiding this comment.
By doing this here - instead of requiring an explicit list of files as input to the creator basically means that this logic with resolving e.g. $F4 which is essentially Houdini-specific now makes this Creator houdini targeted only whereas it would be great that this could work as an even lower-level generic creator ... anywhere.
So basically I do like this - but let's keep thinking about how, by design, this exact same lower level logic can run anywhere without being houdini specific. This "runtime instance" may very well run in a python process on the farm outside of Houdini for example.
There was a problem hiding this comment.
what about passing the representation to the creator.
and in each DCC we should compute it and pass it to the creator.
taking reference from fabia's demo.
and then creator can compute frame start and end from the input files.
| files = pre_create_data.get("files", []) | ||
| if files: | ||
| representations = [create_representation_data(files)] | ||
|
|
||
| output_paths = pre_create_data.get("output_paths", []) | ||
| if output_paths: |
There was a problem hiding this comment.
We should remove one of these two - have a single entry point that is used for the creator which we use as the "API". By exposing more ways we're just adding complexity ;)
By the way, output_paths really got me confused because I see these files actually as the 'input files' for the created instance (since basically this runtime instance expects the files to pre-exist hehe). Anyway, just files or paths or filepaths should suffice.
| @@ -20,11 +22,75 @@ def create_representation_data(files): | |||
| return { | |||
| "name": ext, | |||
| "ext": ext, | |||
| "files": files if len(files) > 1 else first_file, | |||
| "files": files if len(files) > 1 else filename, | |||
There was a problem hiding this comment.
Ah, yes - that fixes a bug. Thanks!
|
@MustafaJafar would you like me pick this up? |
feel free to do so ^^ |
|
This PR was made to test supporting multiple representations in a wip feature generic publish. |
|
Thanks - actually some of it is still very relevant. I just need to fix it the right way 😄 so still thanks a lot for generating this draft! |
Changelog Description
Support multiple representations in batch publishing
This PR extends ynput#542
Additional info
I used this script https://gist.github.com/MustafaJafar/bd2a388e4a6aa3613d64a186ebb6660c to test this PR
Testing notes: