Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run CI for every commit in PR #1275

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

NickeZ
Copy link
Collaborator

@NickeZ NickeZ commented Aug 17, 2024

  • Split out Pull Request CI into separate file
  • Dispatch one job per commit in PR

I've tested it quite thoroughly on my fork of the repo in github.

@NickeZ NickeZ requested a review from benma August 17, 2024 15:49
* Split out Pull Request CI into separate file
* Dispatch one job per commit in PR
@@ -14,4 +18,4 @@ jobs:
- name: Pull CI container image
run: ./.ci/run-container-ci pull
- name: Run CI in container
run: ./.ci/run-container-ci ${{github.workspace}} ${{github.base_ref}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.base_ref is only available when the event type is pull request. Therefore we remove it.

Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickeZ NickeZ merged commit f7f0e6b into BitBoxSwiss:master Aug 18, 2024
1 check passed
@NickeZ NickeZ deleted the ci-per-commit branch August 20, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants