Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest Log Improvement #50

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tofame
Copy link
Contributor

@Tofame Tofame commented Jan 7, 2025

This is the beginning of quest log improvement.

It should be a draft for now, and that is because I suggest sending an additional byte (isCompleted for missions) the OTC/Cipsoft will break unless modified. So, we would have to supply OTC for Black-Tek users.

What this improves:

  1. Mission isCompleted state is specified for client, instead of just changing name server-side (Quests already do that.)
  2. sendQuestLog(); is now used when questlog update happens. Currently, in all implementations of quest log client spamms requests for questlog which is a very bad idea. By doing this, we can remove a lot of redundancy client-side, and let server handle updates, instead of relying on client asking server for it all the time.

@LuanGP
Copy link
Contributor

LuanGP commented Jan 8, 2025

I dont know if that is the proposal of blacktek, lose the possibility of use cipsoft client.
Anyway, it looks an nice improvement.

@Tofame
Copy link
Contributor Author

Tofame commented Jan 8, 2025

I dont know if that is the proposal of blacktek, lose the possibility of use cipsoft client. Anyway, it looks an nice improvement.

BlackTek is not going to continue being compatible with cipsoft in the future (only current versions are doing it, but thats also why I keep it as a "Draft" and not PR).

Anyway, I just realised server-side update with sendQuestLog();, wont be enough, since it updates quests, but missions of those quests need update too (if someone uses quest tracker)... So new packet needs to be considered or some new method to send update of both quests and missions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants