Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
There is an error in the driver code, in the function ctucan_set_secondary_sample_point of the file ctucanfd_base.c.
According to the datasheet (see section 3.1.46 CTU_CANFD_Datasheet.pdf), Secondary Sampling Point is not used when SSP_SRC = 0b01. This is true when the bit rate is less than or equal to 1 Mbit/s. But if the CAN FD interface works with a higher data bit rate, for example 4 or 5 Mbit/s, then the transceiver delay value becomes significant and you need to use SSP_SRC = 0x0 or 0x2.
However, in the driver for bitrate greater than 1 Mbit/s
ssp_cfg |= FIELD_PREP(REG_TRV_DELAY_SSP_SRC, 0x1);