Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2097] Added Prefhelper tests #1308

Merged
merged 8 commits into from
Oct 25, 2023
Merged

[SDK-2097] Added Prefhelper tests #1308

merged 8 commits into from
Oct 25, 2023

Conversation

nsingh-branch
Copy link
Contributor

Reference

SDK-2097 -- iOS Test coverage

Summary

Added tests to ensure prefhelper values are being properly set and retrieved. Also updated the testbed's Branch Key.

Motivation

Increase the iOS SDK's test coverage.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

Run the tests and confirm the succeed locally and on GHA.

cc @BranchMetrics/saas-sdk-devs for visibility.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1308 (97ca6bb) into master (60b8a62) will increase coverage by 0.09%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   50.48%   50.57%   +0.09%     
==========================================
  Files          68       68              
  Lines       10106    10109       +3     
  Branches     3889     3889              
==========================================
+ Hits         5102     5113      +11     
+ Misses       4758     4748      -10     
- Partials      246      248       +2     

see 11 files with indirect coverage changes

@echo-branch echo-branch merged commit c4b9e0c into master Oct 25, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants