Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-2208 replace bnc field defines #1347

Closed
wants to merge 3 commits into from

Conversation

echo-branch
Copy link
Contributor

Reference

SDK-2208 replace BNC field defines.

Summary

BNCFieldDefines.h was replaced with regular Objective-C code. Mostly equivalent code was added to a category.

Motivation

This is to unblock a fix for non-Xcode versions of SPM.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Existing functionality and unit tests should work.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6e9ee) 50.73% compared to head (f005401) 50.81%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   50.73%   50.81%   +0.07%     
==========================================
  Files          68       67       -1     
  Lines       10081    10092      +11     
  Branches     3864     3789      -75     
==========================================
+ Hits         5115     5128      +13     
+ Misses       4708     4707       -1     
+ Partials      258      257       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@echo-branch
Copy link
Contributor Author

I merged this into the PR for tuist as this is blocking cocoapods functionality. We only need to merge the other one, but this isolates the change for this.
#1349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants