Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The original code used boolValue #1356

Merged
merged 1 commit into from
Feb 27, 2024
Merged

The original code used boolValue #1356

merged 1 commit into from
Feb 27, 2024

Conversation

echo-branch
Copy link
Contributor

@echo-branch echo-branch commented Feb 26, 2024

Reference

SDK-2250

Summary

Swap unused string check from doubleValue to boolValue

Motivation

Be consistent with the code it is intended to replace.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Unit test has been updated. Note this utility code isn't actually used by the SDK.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (16aae6a) to head (1b03a81).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   51.51%   51.27%   -0.24%     
==========================================
  Files          66       66              
  Lines       10092    10092              
  Branches     3698     3697       -1     
==========================================
- Hits         5199     5175      -24     
- Misses       4628     4654      +26     
+ Partials      265      263       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@echo-branch echo-branch merged commit 5612c07 into master Feb 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants