Static Framework Missing IDFA Fix #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsingh-branch
approved these changes
May 30, 2024
gdeluna-branch
approved these changes
Jun 7, 2024
gdeluna-branch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2408 -- Investigate loss of AdSupport for Spotify
https://branch.atlassian.net/browse/SDK-2408
Summary
Fixed script names in "Run Script" phase of targets static-xcframework and static-xcframework-noidfa.
Type Of Change
Testing Instructions
IDFA Support
Generate a static framework by running script. -
/scripts/prep_static_xcframework.sh
This will generate a static framework with IDFA support.
Link this framework to a test app with ATTrackingmanager support ( https://help.branch.io/developers-hub/docs/ios-advanced-features#include-apples-attrackingmanager).
Build and Run App. Check logs if idfa is present in requests -
IDFA Excluded
Generate a static framework by running script. -
./scripts/prep_static_xcframework_noidfa.sh
This will generate a static framework without IDFA support (Macro BRANCH_EXCLUDE_IDFA_CODE is enabled )
Link this framework to a test app with ATTrackingmanager support ( https://help.branch.io/developers-hub/docs/ios-advanced-features#include-apples-attrackingmanager).
Build and Run App. Check logs if idfa is NOT present in requests -
Also, logs print following message
[BranchSDK][Debug][BNCDeviceInfo checkAdvertisingIdentifier] BRANCH_EXCLUDE_IDFA_CODE flag enabled. IDFA is not availableI am also attaching here static framework (with IDFA enabled) for testing.
Branch_static.zip
cc @BranchMetrics/saas-sdk-devs for visibility.