Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Configuration #747

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Lint Configuration #747

merged 12 commits into from
Sep 2, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Sep 1, 2024

  • Lints idents no longer include E or W
  • Lints can be disabled in TOML
  • Lints can have configuration options
  • Lints have minimum severity (Can not set a fatal lint to a Warning)
  • Convert all Config linting
  • Convert all SQF linting
  • Automatically generate book documentation from Rust code
  • Messages in terminal can link to the book

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 58.23328% with 1461 lines in your changes missing coverage. Please review.

Project coverage is 66.3%. Comparing base (3c142e1) to head (0d00270).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/analyze/lints/s02_event_handlers.rs 13.8% 418 Missing ⚠️
book-lints/src/main.rs 0.0% 129 Missing ⚠️
libs/workspace/src/lint.rs 61.7% 101 Missing ⚠️
.../src/analyze/lints/s01_command_required_version.rs 25.0% 96 Missing ⚠️
.../src/analyze/lints/c09_magwell_missing_magazine.rs 60.9% 59 Missing ⚠️
...s/sqf/src/analyze/lints/s07_select_parse_number.rs 68.1% 58 Missing ⚠️
libs/common/src/config/project/lint.rs 50.0% 52 Missing ⚠️
libs/sqf/src/analyze/lints/s03_static_typename.rs 62.0% 49 Missing ⚠️
...nfig/src/analyze/lints/c05_external_parent_case.rs 74.0% 43 Missing ⚠️
.../config/src/analyze/lints/c08_missing_semicolon.rs 59.4% 43 Missing ⚠️
... and 23 more
Additional details and impacted files
Files with missing lines Coverage Δ
libs/common/src/config/mod.rs 37.5% <ø> (ø)
libs/common/src/config/project/mod.rs 97.6% <100.0%> (+0.1%) ⬆️
libs/config/src/analyze/cfgpatch.rs 50.0% <ø> (ø)
libs/config/src/analyze/chumsky.rs 0.0% <ø> (ø)
libs/config/src/model/class.rs 93.3% <100.0%> (+3.3%) ⬆️
libs/config/src/model/config.rs 93.3% <100.0%> (+1.3%) ⬆️
libs/preprocessor/src/processor/mod.rs 89.1% <ø> (ø)
libs/workspace/src/addons.rs 92.2% <100.0%> (+0.4%) ⬆️
libs/workspace/src/lib.rs 94.3% <ø> (ø)
libs/workspace/src/reporting/mod.rs 88.0% <100.0%> (+1.6%) ⬆️
... and 34 more

... and 1 file with indirect coverage changes

@BrettMayson BrettMayson marked this pull request as draft September 1, 2024 07:59
@BrettMayson BrettMayson marked this pull request as ready for review September 2, 2024 04:35
@BrettMayson
Copy link
Owner Author

Test coverage isn't great on this, but I have tested everything locally.

Honestly testing could use a refactor as well, would be nice to find a better way to do it and test as many good and bad paths are we can

@BrettMayson BrettMayson merged commit 2f39e8b into main Sep 2, 2024
29 of 31 checks passed
@BrettMayson BrettMayson deleted the diag_rework branch September 2, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant