Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization: handle subaddons #820

Merged
merged 2 commits into from
Nov 1, 2024
Merged

localization: handle subaddons #820

merged 2 commits into from
Nov 1, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Oct 31, 2024

Fixes #819

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 26.38889% with 53 lines in your changes missing coverage. Please review.

Project coverage is 69.1%. Comparing base (eef86bc) to head (20fc58e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/commands/localization/sort.rs 0.0% 38 Missing ⚠️
bin/src/modules/stringtables/mod.rs 69.5% 7 Missing ⚠️
libs/stringtable/src/analyze/lints/01_sorted.rs 22.2% 7 Missing ⚠️
libs/stringtable/src/analyze/mod.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/stringtable/src/analyze/mod.rs 46.4% <50.0%> (ø)
bin/src/modules/stringtables/mod.rs 44.7% <69.5%> (+1.2%) ⬆️
libs/stringtable/src/analyze/lints/01_sorted.rs 27.4% <22.2%> (ø)
bin/src/commands/localization/sort.rs 0.0% <0.0%> (ø)

@BrettMayson BrettMayson merged commit 6d92452 into main Nov 1, 2024
34 of 37 checks passed
@BrettMayson BrettMayson deleted the stringtable_subaddons branch November 1, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hemtt localization sort doesn't handle subaddons
1 participant