feat: implemented personal builder profile page #16
Conversation
|
@michojekunle is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
@phipsae @technophile-04 made this PR as regards this issue #9 please review |
There was a problem hiding this comment.
@michojekunle thanks for the page! You really like that you integrate the particles effect :)
Below you'll find comments regarding the code. If there are any questions feel free to ask.
Thanks!
package-lock.json
Outdated
There was a problem hiding this comment.
We don't want the package-lock.json file, as we use yarn. So please remove this file.
There was a problem hiding this comment.
Here you could also name the folder after your name, so you have a dedicated folder for your page.
| import { useCallback, useEffect, useState } from "react"; | ||
| import Image from "next/image"; | ||
| import Link from "next/link"; | ||
| import { Check, Code, Copy, Cpu, Github, Globe, Linkedin, Twitter } from "lucide-react"; |
There was a problem hiding this comment.
For Github, LinkedIn, Twitter it gives me deprecated warning. Maybe you want to consider to change to another library, like react icons.
yarn.lock
Outdated
There was a problem hiding this comment.
The only code change should be the addition of "lucide-react."
| ) : ( | ||
| <Copy className="w-3 h-3 ml-2 cursor-pointer transition" onClick={handleCopy} /> | ||
| )} | ||
| </span> |
There was a problem hiding this comment.
You might consider using the SE2 component Address to leverage the existing component. There you already have the copy functionality.
| ]; | ||
|
|
||
| return ( | ||
| <div className="relative min-h-screen overflow-hidden bg-gradient-to-br from-base-200 to-base-300"> |
There was a problem hiding this comment.
Your Floating Particles work perfectly in light mode.
But in dark mode you cannot see it, so you might adapt that.
packages/nextjs/app/builders/0x7429CbD5eD20736645723E972bE60B7F6BF5959c/page.tsx
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @phipsae Thank you so much for your review, I've made the necessary and suggested changes as specified in the comments, and I also learnt new stuff regarding disabling SSR for client pages. Please review 🙌🏾
Hi @phipsae Thank you so much for your review, I've made the necessary and suggested changes as specified in the comments, and I also learnt new stuff regarding disabling SSR for client pages. Please review 🙌🏾 Here's the new look
|
|
|
||
| const DevvMichaelProfile = dynamic(() => import("./_components/DevvMichaelProfile"), { ssr: false }); | ||
|
|
||
| export default DevvMichaelProfile; |
There was a problem hiding this comment.
You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page and also aligns with all the other builder pages.
There was a problem hiding this comment.
Alright, Awesome, I'm on it
There was a problem hiding this comment.
Hi @phipsae, Thank you so much for the review. I've implemented the changes
|
Very nice, thank you a lot!!! |
Description
Implemented personal builder profile page, that shows my details, my avatar, a short bio and my address
Additional Information
Your ENS/address: 0x7429CbD5eD20736645723E972bE60B7F6BF5959c