Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and Display Builder Count from BatchRegistry Contract #17

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

Superior212
Copy link
Contributor

@Superior212 Superior212 commented Oct 18, 2024

Description

This pull request addresses the display of the number of builders who have checked into the contract within the packages/nextjs/app/page.tsx file. Currently, a placeholder string "To Be implemented" is displayed, which does not provide any useful information to users.

Screenshot 2024-10-18 at 10 51 47 PM

Proposed Changes

  • Replace the placeholder string with the actual count of builders who have checked in, which will be retrieved from the BatchRegistry contract.

  • Implement a method to fetch this count and ensure it updates dynamically when the data changes.

  • I have read the contributing docs (if this is your first contribution)

  • This is not a duplicate of any existing pull request

_Closes #5

Address:0x62CeF3Ca8b52a9C69a17236CA2c56Cdb7a383E8e

Copy link

vercel bot commented Oct 18, 2024

@Superior212 is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch10-buidlguidl-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:23pm

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation!

Below you'll find some comments.

Let me know if something is not clear.

(Just a little advice: If you have something like that in the description of the PR, make sure to check to boxes. )
Screenshot 2024-10-21 at 10 08 44

packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
@Superior212
Copy link
Contributor Author

Superior212 commented Oct 21, 2024

@phipsae i have refactor the page kindly review

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments!
Just a little thing to change, see below.

packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/page.tsx Outdated Show resolved Hide resolved
@Superior212
Copy link
Contributor Author

Superior212 commented Oct 23, 2024

@phipsae I have adjusted the suggestions. I hope we are good to go.

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little thing to change and then we are good to go.

packages/nextjs/app/page.tsx Show resolved Hide resolved
@Superior212
Copy link
Contributor Author

Superior212 commented Oct 23, 2024

@phipsae have remove the <p> tag

@phipsae
Copy link
Collaborator

phipsae commented Oct 23, 2024

Thank you! So let's merge!

@phipsae phipsae merged commit 90623aa into BuidlGuidl:main Oct 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants