Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes read_and_create_initial_systems. This function is called in the init of a Facility. It reads the systems from the xml, and if it doesn't have any, provides some defaults.
Now, a close look at function will find a handful of questionable choices, but let's zero down on 3:
In this PR I:
why do not merge?
the change in how defaults breaks things a little. We are in converstations about how and where defaults should be set.