Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steam networking testing #1

Merged
merged 63 commits into from
Jan 6, 2025
Merged

Steam networking testing #1

merged 63 commits into from
Jan 6, 2025

Conversation

BurntRanch
Copy link
Owner

No description provided.

@BurntRanch
initial commit
31de38c
@BurntRanch
better logging
25dbede
@BurntRanch
what was i thinking
8763c01
@BurntRanch
some improvements to client
7d45507
@BurntRanch
so THATS why
8141fdf
@BurntRanch
callback changes
5abaabe
@BurntRanch
IT WORKS!!!!!!!
b9860ee
@BurntRanch
added tick system to avoid 100% CPU usage
55a64a6
@BurntRanch
remove spammy logging, will come back but not rn
3b250f2
@BurntRanch
change compile flags
85bc94a
@BurntRanch
Fix a crash where if the app isn't hosting a game server and has atle…
54b73c0 
…ast 1 client it would crash on exit.
@BurntRanch
initial networking test
46f93f8
@BurntRanch
initial deserialization test
f01af03
@BurntRanch
fix switch-case statements falling through
c123aee
@BurntRanch
fix incorrect status polling
d29ca70
@BurntRanch
minor changes to networking
eba36dc
@BurntRanch
a little adjustment to serialization code
0ca20f9
@BurntRanch
testing..
b751526
@BurntRanch
fix compile error
eb6467c
@BurntRanch
remove hard-requirement for m_Renderer to be initialized to support h…
064c3f3 
…eadless Engine usage
@BurntRanch
fix status polling once and for all.
469745c
@BurntRanch
it should work now!!!!
8cc6467
@BurntRanch
test scene path sharing over the network
1b1e12a
@BurntRanch
improve deserialization
85743b8
@BurntRanch
event system
8a28a69
@BurntRanch
partial update support
de35296
@BurntRanch
remove requirement for 1 connection in client thread
d5655f1
@BurntRanch
improve synchronization by.. actually synchronizing (the code before …
7f36cd3 
…wasn't working at all)
@BurntRanch
fix delta updates
9bf1d42
@BurntRanch
fix invalid pointer dereference
12ba4be
BurntRanch and others added 27 commits December 25, 2024 16:12
@BurntRanch
define HighestObjectID
8eee385
@BurntRanch
"Hm, looks redundant, let me remo- OHH thats why.."
7656ee6
@BurntRanch
add tick update handlers
0e474a9
@BurntRanch
experimental changes to network event processing
d1b43d0
@BurntRanch
remove redundant lines
e4f37b0
@BurntRanch
fix compile + run time errors
0eaac06
@BurntRanch
fix object syncing once and for all!
640c94d 
this project is making me depressed
@BurntRanch
Also fix the children not being included
da0b97d
@BurntRanch
remove pointless source files
c5afb67
@BurntRanch
experimental update
ee9f2f0
@BurntRanch
fix compile errors
50e4670
@BurntRanch
some fixes for the client-side
bb23287
@BurntRanch
solve a few TODOs
4ae998c
@BurntRanch
ignore the broken goodbye message
f9d0707
@BurntRanch
I tried
19e90b4
@BurntRanch
add event support
2ceeb0f
@BurntRanch
experimental camera rework
f1064ee
@BurntRanch
fix compile error
bfc171f
@BurntRanch
fix crashes
967c570
@BurntRanch
Fix FOV importing
7ea6ec4
@BurntRanch
i hate cameras somuch
1f26c8b
@BurntRanch
i really hate cameras
055e7e2
@BurntRanch
some logging + remove object placeholder values
472e579
@BurntRanch
*sigh* finally...
68b8c5e
@BurntRanch
it's over.. cameras work now...
6926772
@BurntRanch
Remove hardcoded Front value (still works)
ac03354
@Toni500github
Merge branch 'main'
fe16a03
@BurntRanch BurntRanch merged commit 25ebe17 into main Jan 6, 2025
1 check passed
@BurntRanch BurntRanch deleted the steam_networking_testing branch January 6, 2025 10:57
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 6, 2025
View reviewed changes
src/engine.cpp
}
if (msgCount > 0) {
for (int i = 0; i < msgCount; i++) {
ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));

Check failure

Code scanning / CodeQL

Suspicious add with sizeof High

Suspicious sizeof offset in a pointer arithmetic expression. The type of the pointer is
ISteamNetworkingMessage *
Loading
.

Copilot Autofix AI 10 days ago

To fix the problem, we need to remove the manual scaling by sizeof(ISteamNetworkingMessage) in the pointer arithmetic expression. Instead of adding i * sizeof(ISteamNetworkingMessage) to incomingMessages, we should simply add i to it. This will correctly compute the offset based on the size of ISteamNetworkingMessage.

  • Change the line where incomingMessage is calculated by removing the multiplication by sizeof(ISteamNetworkingMessage).
  • The file to edit is src/engine.cpp.
  • No additional methods, imports, or definitions are needed to implement this change.
Suggested changeset 1
src/engine.cpp

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/engine.cpp b/src/engine.cpp
--- a/src/engine.cpp
+++ b/src/engine.cpp
@@ -3113,3 +3113,3 @@
             for (int i = 0; i < msgCount; i++) {
-                ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));
+                ISteamNetworkingMessage *incomingMessage = incomingMessages + i;
 
EOF
@@ -3113,3 +3113,3 @@
for (int i = 0; i < msgCount; i++) {
ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));
ISteamNetworkingMessage *incomingMessage = incomingMessages + i;

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
src/engine.cpp
}
if (msgCount > 0) {
for (int i = 0; i < msgCount; i++) {
ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));

Check failure

Code scanning / CodeQL

Suspicious add with sizeof High

Suspicious sizeof offset in a pointer arithmetic expression. The type of the pointer is
ISteamNetworkingMessage *
Loading
.

Copilot Autofix AI 10 days ago

To fix the problem, we need to remove the manual scaling by sizeof(ISteamNetworkingMessage) in the pointer arithmetic. Instead of using incomingMessages + (i * sizeof(ISteamNetworkingMessage)), we should simply use incomingMessages + i. This will correctly compute the address of the i-th element in the array of ISteamNetworkingMessage pointers.

Suggested changeset 1
src/engine.cpp

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/engine.cpp b/src/engine.cpp
--- a/src/engine.cpp
+++ b/src/engine.cpp
@@ -3233,3 +3233,3 @@
             for (int i = 0; i < msgCount; i++) {
-                ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));
+                ISteamNetworkingMessage *incomingMessage = incomingMessages + i;
 
EOF
@@ -3233,3 +3233,3 @@
for (int i = 0; i < msgCount; i++) {
ISteamNetworkingMessage *incomingMessage = incomingMessages + (i * sizeof(ISteamNetworkingMessage));
ISteamNetworkingMessage *incomingMessage = incomingMessages + i;

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurntRanch @Toni500github