feat: VoidESP #5199
feat: VoidESP #5199
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/render/ModuleVoidESP.kt
Fixed
Show fixed
Hide fixed
| private val tickHandler = handler<PlayerTickEvent> { | ||
| val positions = search() | ||
|
|
||
| // Invalidate last tick positions | ||
| with(lastTickPositions.longIterator()) { | ||
| while (hasNext()) { | ||
| val longValue = nextLong() | ||
| if (longValue !in positions) { | ||
| renderer.removeBlock(mutable.set(longValue)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Add this tick positions | ||
| with(positions.longIterator()) { | ||
| while (hasNext()) { | ||
| val longValue = nextLong() | ||
| renderer.addBlock(mutable.set(longValue)) | ||
| } | ||
| } | ||
|
|
||
| lastTickPositions = positions | ||
|
|
||
| // Update cull data | ||
| renderer.updateAll() | ||
| } |
There was a problem hiding this comment.
We don't do that. Look in BlockESP how it's done.
There was a problem hiding this comment.
The BlockESP does not have animations for changes, so I asked @ccetl about how to use the PlacementRenderer
There was a problem hiding this comment.
We don't do that. Look in BlockESP how it's done.
BlockESP doesn't have animations nor culling which is especially important if the blocks disappear / appear in a short distance. But to some degree i agree, you don't have to introduce a separate list here as the renderer has in/current lists already. But IMO it's fine.
There was a problem hiding this comment.
The BlockESP does not have animations for changes, so I asked @ccetl about how to use the PlacementRenderer
That is not the problem. You scan the region around the player every tick. This is inefficient.
There was a problem hiding this comment.
Ah I didn't realize that you meant that, sorry.
There was a problem hiding this comment.
The BlockESP does not have animations for changes, so I asked @ccetl about how to use the PlacementRenderer
That is not the problem. You scan the region around the player every tick. This is inefficient.
But in my profiler this doesn't spend long time to check. The HoleESP-like scanning might make the code more complicated
|
Like in bedwars the bridge was broken by someone and you are walking without notice of that, this can remind you of that |
|
|
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/render/ModuleVoidESP.kt
Fixed
Show fixed
Hide fixed
This should definitely be done by people who maintain the individual languages. If we just fill the translation files with gtranslate/deepl translations it will sound bad in many cases and then we could quit manually adding translations and just make a dynamic translation automation. |
| } | ||
|
|
||
| private val mutable = BlockPos.Mutable() | ||
| private val mutable1 = BlockPos.Mutable() |
VoidESP.mp4