-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend progress bar #27
Conversation
thanks for sending these screenshots over @nickbristow ! there a few changes that need to be made, happy to either pair on it or review again async:
|
thanks for sending more screenshots, it's still looking like the first heading text and spacing won't be aligned with what Kenneth had for the first two pages, which will be a jarring transition for users the three things that stand out visually is that there should be 48 px of spacing between the page navigation header and the "Processing your eCR" text, and then it looks like the "Processing your eCR text" is not public sans, not sure what's happening there. additionally, I'd ask Kenneth what spacing he has between the "Processing your eCR" text and the subtitle below it because it looks decently smaller in these screenshots additionally, more spacing to confirm is accurate:
I think thats all, just spacing to be fixed and the typeface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Nick thanks!
PULL REQUEST
Summary
Implemented progress bar
Related Issue
Fixes # https://app.zenhub.com/workspaces/secret-6480bf2ee530095ab41ebbe9/issues/gh/cdcgov/phdi/818
Additional Information
Anything else the review team should know?