Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2주차] 객체지향 코드 연습 (Seooooo24) #32
base: main
Are you sure you want to change the base?
[2주차] 객체지향 코드 연습 (Seooooo24) #32
Changes from 10 commits
d6d489e
597b2b6
f54b598
f128525
6343aac
927c289
e27d52c
4c41108
4e4e218
dc33e18
57d005b
93ab4bb
b22b652
962bb59
bc1c595
0b543fa
c85416a
45be801
3467293
0272de2
1bad3d8
a6fb766
2fd8fa5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
초기화 시점이 언제인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lotto클래스 내부에 List 타입의 numbers가 있는데, Lotto클래스를 활용해보는 것이 더 좋아보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List와 같이 자료형의 이름을 변수명에 쓴다면, 나중에 자료형이 변경되었을 때 해당 변수명도 같이 변경되어야 하고 그 변수를 사용하는 다른 곳에도 영향이 끼치기에 자료형은 복수형으로 사용하는 것이 좋습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mLotto가 사용되고 있지 않은 것 같습니다. 무슨 목적으로 생성했던 것인지 의도가 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 연관 관계를 Application이 관리하는게 맞을까?를 고민해보시면 좋을거 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum 메소드로 관리해도 좋을 것 같아요. 막연하지만?? 한번 생각해보면 좋을 것 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성자 내에 비즈니스 로직과 관련된 메소드를 수행하는 게 적절하지 않은 것 같습니다. 필드를 정의하는 코드만 작성해주는 것이 좋습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else if 사용을 자제해주세요.
early return 방법 사용해주시길 바랍니다.