feat: [FYI] RangeChecker/RangeCompiler to support 1/2/3 args #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Sep 4, 2024
| from guppylang.compiler.expr_compiler import python_value_to_hugr | ||
| from guppylang.definition.custom import CustomFunctionDef | ||
|
|
||
| # Find the builtins module. Brute-force search! |
There was a problem hiding this comment.
This is the worst bit! Custom Checkers get access to the Func + full Context, Compilers only get the CompiledGlobals which is rather hard to use
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## acl/range_one #453 +/- ##
=================================================
- Coverage 92.58% 92.48% -0.10%
=================================================
Files 49 49
Lines 5555 5591 +36
=================================================
+ Hits 5143 5171 +28
- Misses 412 420 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.