Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add format and issue handling #1

Merged
merged 11 commits into from
Jan 10, 2025
Merged

add format and issue handling #1

merged 11 commits into from
Jan 10, 2025

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Jan 9, 2025

No description provided.

@cqc-melf cqc-melf requested review from trvto and cqc-alec January 9, 2025 14:58
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@cqc-melf cqc-melf requested review from cqc-alec and qartik January 9, 2025 16:10
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@cqc-melf
Copy link
Collaborator Author

cqc-melf commented Jan 9, 2025

@qartik Can you maybe take a look at the ruff.toml and recommend what you think should be added?

@qartik
Copy link
Member

qartik commented Jan 9, 2025

I suggest all at https://github.com/CQCL/pytemplate/blob/main/ruff.toml to begin with (and removing the ignores from that file). Based on how this project involves, you may want to deselect some that you don't find useful. The full reference is at https://docs.astral.sh/ruff/rules/

.github/workflows/lint.yml Outdated Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
@doug-q doug-q mentioned this pull request Jan 10, 2025
cqc-melf and others added 3 commits January 10, 2025 11:14
@cqc-melf
Copy link
Collaborator Author

I suggest all at https://github.com/CQCL/pytemplate/blob/main/ruff.toml to begin with (and removing the ignores from that file). Based on how this project involves, you may want to deselect some that you don't find useful. The full reference is at https://docs.astral.sh/ruff/rules/

Like this?

@cqc-melf cqc-melf requested a review from qartik January 10, 2025 11:16
@qartik
Copy link
Member

qartik commented Jan 10, 2025

Is this primarily a Python project or Rust? #2 seems to suggest a mix of both.

@cqc-melf cqc-melf merged commit 6c9c3f4 into main Jan 10, 2025
1 check passed
@cqc-melf
Copy link
Collaborator Author

Is this primarily a Python project or Rust? #2 seems to suggest a mix of both.

Both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants