Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semver-checks): Post comments on pull_request_targets #27

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

aborgna-q
Copy link
Collaborator

#22 changed the recommended trigger for the semver checks action to pull_request_target, but inside the action we were still checking for pull_request targets explicitly so the comments never got posted.

Note that for both events the payload is still called pull_request, so there's no need to change the rest of the code.
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target

@aborgna-q aborgna-q requested a review from cqc-alec November 27, 2024 11:11
@aborgna-q aborgna-q requested a review from a team as a code owner November 27, 2024 11:11
@aborgna-q aborgna-q added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 15f11e6 Nov 27, 2024
1 check passed
@aborgna-q aborgna-q deleted the ab/semver-checks-guards branch November 27, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants