Remove not working testcases #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Dec 13, 2023
tests/integration/backend_test.py
Outdated
| ], | ||
| ) | ||
| @pytest.mark.timeout(120) | ||
| def test_division( |
There was a problem hiding this comment.
Rather than delete these tests we could modify them so that they expect an exception to be raised; then swap the "xfail" annotation between QASM and QIR.
(I think we will want to support both these cases one day.)
There was a problem hiding this comment.
Good point, done in the added commits.
cqc-alec
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove testcases that should not work