Skip to content

Commit

Permalink
Fix Demo Bugs (#43)
Browse files Browse the repository at this point in the history
* Bathy Bug

* Remove tides from pytet demo

* Try adding ipykernel
  • Loading branch information
manishvenu authored Jan 23, 2025
1 parent a87846d commit 91d4d32
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 4 additions & 1 deletion demos/reanalysis-forced.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@
"metadata": {},
"outputs": [],
"source": [
"# NBVAL_SKIP\n",
"# Tidal files are not available in the repository, and must be requested from the TPXO website\n",
"expt.setup_boundary_tides(\n",
" tide_h_path,\n",
" tide_u_path,\n",
Expand Down Expand Up @@ -440,7 +442,8 @@
"metadata": {},
"outputs": [],
"source": [
"expt.setup_run_directory(surface_forcing = \"era5\", with_tides = True)"
"expt.setup_run_directory(surface_forcing = \"era5\", with_tides = False)\n",
"# When tides files are found, run the previous command with parameter with_tides = True"
]
},
{
Expand Down
1 change: 1 addition & 0 deletions docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ myst-parser
sphinx-book-theme
nbsphinx
IPython
ipykernel
4 changes: 2 additions & 2 deletions regional_mom6/regional_mom6.py
Original file line number Diff line number Diff line change
Expand Up @@ -2022,8 +2022,8 @@ def tidy_bathymetry(
bathymetry = xr.Dataset(
{"depth": (["ny", "nx"], bathymetry[vertical_coordinate_name].values)},
coords={
"lon": (["nx", "ny"], bathymetry[longitude_coordinate_name].values),
"lat": (["nx", "ny"], bathymetry[latitude_coordinate_name].values),
"lon": (["ny", "nx"], bathymetry[longitude_coordinate_name].values),
"lat": (["ny", "nx"], bathymetry[latitude_coordinate_name].values),
},
)
bathymetry.attrs["depth"] = "meters"
Expand Down

0 comments on commit 91d4d32

Please sign in to comment.