Skip to content

Commit

Permalink
daemon/ratelimiting: fix runtime configuration reload
Browse files Browse the repository at this point in the history
  • Loading branch information
Lukáš Ondráček committed Oct 30, 2024
1 parent 7964bd7 commit 9cf96be
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion python/knot_resolver/manager/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def config_nodes(config: KresConfig) -> List[Any]:
config.logging,
config.monitoring,
config.lua,
config.rate_limiting,
]

# register and immediately call a verifier that validates config with 'canary' kresd process
Expand Down Expand Up @@ -215,7 +216,7 @@ async def validate_config(self, _old: KresConfig, new: KresConfig) -> Result[Non
if _old.rate_limiting != new.rate_limiting:
logger.debug("Unlinking shared RRL memory")
try:
os.unlink(str(_old.rundir) + "/rrl")
os.unlink(str(_old.rundir) + "/ratelimiting")
except FileNotFoundError:
pass
logger.debug("Testing the new config with a canary process")
Expand Down

0 comments on commit 9cf96be

Please sign in to comment.