Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Fatal error: Unparenthesized a ? b : c ? d : e is not supported. #3622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dd32
Copy link

@dd32 dd32 commented Sep 21, 2020

Clarify some ternary operators causing a PHP fatal error under PHP8.

Fixes #3621

@faisal-alvi
Copy link

Can anyone please put this up as soon as possible? Because of this problem, we are stuck.

@jeffpaul
Copy link

@New0 any chance you can help get this reviewed/merged/released as it's causing some alerts on PHP compatibility for sites/applications using Caldera Forms... thanks!

@New0
Copy link
Collaborator

New0 commented Feb 28, 2023

Hello @jeffpaul I wish I could be of better help but Caldera Forms is not published on WordPress.org and supported anymore.

In order to apply the change from this PR and maintain Caldera Forms installations, I would suggest forking Caldera Forms.

After Forking this repo, applying changes would consist in
1 - Reproduce this PR on the forked repository ( other dependencies upgrading/changes needed may be tested on other PRs ),
2 - Run a release build -> Set a new version number on the package.json file and maybe a note about that version in readme.txt then run yarn package command ( more details at https://github.com/CalderaWP/Caldera-Forms/blob/master/README.md )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP8 Compatibility
4 participants