Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vault-approle-token from docker secrets #836

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Oct 25, 2024

This gets rid of the warnings from Vault about our approle token ID not being secure. It also removes yet another of our docker secrets.

On a fresh build, should pass integration tests.

@daisieh daisieh requested a review from mshadbolt October 25, 2024 19:25
@daisieh daisieh requested a review from OrdiNeu October 25, 2024 21:05
@mshadbolt
Copy link
Contributor

I am still seeing the warning on a fresh build

Error logs for vault:
--------------------
354     time="2024-10-25T14:47:39-07:00" level=warning msg="Found orphan containers ([candigv2_keycloak_1 candigv2_fluentd_1]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up."
447     {"request_id":"71aec515-4d85-3685-0c56-fd35cfb39a32","lease_id":"","renewable":false,"lease_duration":0,"data":null,"wrap_info":null,"warnings":["Supplying a custom ID for the token uses the weaker SHA1 hashing instead of the more secure SHA2-256 HMAC for token obfuscation. SHA1 hashed tokens on the wire leads to less secure lookups.","Endpoint ignored these unrecognized parameters: [periodic]"],"auth":{"client_token":"1Y8ep9ahhhjtiCB5w8I7zA","accessor":"OwqVIfBHJ05uU86FzOE03Xg0","policies":["approle","default"],"token_policies":["approle","default"],"metadata":null,"lease_duration":2764800,"renewable":true,"entity_id":"","token_type":"service","orphan":false,"mfa_requirement":null,"num_uses":0}}
--------------------

@mshadbolt
Copy link
Contributor

ignore previous comment, works perfectly for me when I use the actual branch

Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working for me, no more warning

@daisieh daisieh merged commit 89484f3 into develop Oct 25, 2024
1 check passed
@daisieh daisieh deleted the daisieh/vault-tokens branch October 25, 2024 23:07
@daisieh daisieh restored the daisieh/vault-tokens branch October 25, 2024 23:07
daisieh added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants