Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1835: make a self-contained init-minio make target #877

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Nov 21, 2024

I thought that the best way to achieve the goal of having an optional minio server would be to pull all of those bits out of the main make compose targets and consolidate them into one init-minio target. This way, if a user wants to set up a MinIO S3 store for testing or dev, they can easily do so. The access key and secret key are in tmp/secrets.

I removed the candigv2 label from the minio container/image/volumes because otherwise clean-all will grab these too. If you want to get rid of the minio container completely, make clean-minio works.

To test: run make init-minio. You should then have a minio container with its api visible at port 9000. If you run make clean-all, the minio container should remain and still be accessible. Running make clean-minio should get rid of it.

@mshadbolt
Copy link
Contributor

Confirmed that minio targets function as specified. Confirmed that the minio container does not get deleted when running make clean-all, there is a problem though because make clean-all deletes all the secrets, including the minio keys.

Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed clean all no longer deletes minio credentials. LGTM

Did not test actual functionality of minio, lmk if you want me to try anything in that regard.

@daisieh daisieh merged commit f92f8d5 into develop Nov 21, 2024
1 check passed
@daisieh daisieh deleted the daisieh/minio branch November 21, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants