Skip to content

Commit

Permalink
Linter fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
OrdiNeu committed Nov 10, 2023
1 parent 2fed9af commit ade5fa2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/ui-component/ingest/IngestMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function IngestMenu() {
});
}

useEffect(() => ingestError && setIngestState(IngestStates.ERROR), [ingestError]);
useEffect(() => ingestError && setIngestState(IngestStates.ERROR), [ingestError, IngestStates.ERROR]);

function getPage(val) {
if (val === 0)
Expand Down
6 changes: 3 additions & 3 deletions src/views/clinicalGenomic/search/SearchHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { useEffect, useState } from 'react';
import { trackPromise } from 'react-promise-tracker';

import { useSearchResultsWriterContext, useSearchQueryReaderContext } from '../SearchResultsContext';
import { fetchFederationStat, fetchFederation, searchVariant, searchVariantByGene, query } from 'store/api';
import { fetchFederationStat, fetchFederation, query } from 'store/api';

// This will grab all of the results from a query, but continue to consume all "next" from the pagination until we are complete
// This defeats the purpose of pagination, and is frowned upon, but... deadlines
function ConsumeAllPages(url, resultConsumer, service = 'katsu') {
/* function ConsumeAllPages(url, resultConsumer, service = 'katsu') {
const parsedData = {};
const RecursiveQuery = (data, idx) => {
let nextQuery = null;
Expand Down Expand Up @@ -35,7 +35,7 @@ function ConsumeAllPages(url, resultConsumer, service = 'katsu') {
};
return fetchFederation(url, service).then((data) => RecursiveQuery(data, 1));
}
} */

// NB: I assign to lastPromise a bunch to keep track of whether or not we need to chain promises together
// However, the linter really dislikes this, and assumes I want to put everything inside one useEffect?
Expand Down
2 changes: 1 addition & 1 deletion src/views/clinicalGenomic/widgets/sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ function GenomicsGroup(props) {
const [selectedGenes, setSelectedGenes] = useState('');
const [startPos, setStartPos] = useState(0);
const [endPos, setEndPos] = useState(0);
const [timeout, setNewTimeout] = useState(null);
const [_timeout, setNewTimeout] = useState(null);

if (hide) {
return <></>;
Expand Down

0 comments on commit ade5fa2

Please sign in to comment.