Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/footer #118

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Feature/footer #118

merged 12 commits into from
Feb 5, 2024

Conversation

CourtneyGosselin
Copy link
Member

@CourtneyGosselin CourtneyGosselin commented Jan 30, 2024

Ticket(s)

DIG-1350

Related PR

CanDIGv2 PR

Description

Addition of footer to all pages that is responsive to sizing. The footer should include:

  • CanDIG website - CanDIG
  • CanDIG GitHub - CanDIG
  • CanDIG Platform version number - auto populate from whichever version is deployed
  • MoHCCN project link & logo - Home
  • Funding statement: "CanDIG Receives Funds From:"

Screenshots (if appropriate)

After PR

screencapture-candig-docker-internal-5080-summary-2024-01-30-18_08_54

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@CourtneyGosselin CourtneyGosselin changed the title WIP: Feature/footer Feature/footer Jan 31, 2024
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled the branch and rebuilt stack. Looked at in Brave and Chrome - both chromium based browsers

A couple of minor bits of feedback:

  • When the summary page loads on my screen, the footer is out of sight of the main page as there is a large gap under the graphs.
    Screenshot 2024-01-31 at 3 17 46 PM

  • Maybe we could reduce this spacing so that the footer shows at the bottom of the page. So minimum spacing would be about the same as the gap at the top with the header but when there is enough space it is anchored to the bottom of the screen.
    Like:
    Screenshot 2024-01-31 at 3 17 46 PM-edits

  • Can we change the capitalisation of the funding statement to: "CanDIG receives funds from:" (sorry I pointed this out earlier on the shared screenshots)

  • Screenshots above don't show it but I played with the CANDIG_VERSION to see that it displays and it worked for me, not sure if it could be confusing about whether this is the version of the entire stack or the data portal itself.

  • Would be nice for the Candig version statement link to the relevant version of the stack? should be easy to add the given version to the url https://github.com/CanDIG/CanDIGv2/releases/tag/v2.1.1 -> https://github.com/CanDIG/CanDIGv2/releases/tag/${CANDIG_VERSION} (however this is done in js that I have no clue about ) this means we do have to ensure the version is input into the .env file correctly when making stable releases to make sure the link isn't broken

src/layout/MainLayout/Footer/index.js Outdated Show resolved Hide resolved
Changed capilization and linking of versioning. Responsiveness bug moved to new JIRA ticket

Signed-off-by: Courtney Gosselin <[email protected]>
@mshadbolt mshadbolt self-requested a review February 1, 2024 23:44
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates! Happy to approve this from a visuals point of view (know nothing about the code so will leave that up to @OrdiNeu )

Copy link
Contributor

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

src/layout/MainLayout/Footer/index.js Outdated Show resolved Hide resolved
src/layout/MainLayout/Footer/index.js Outdated Show resolved Hide resolved
src/layout/MainLayout/Footer/index.js Show resolved Hide resolved
src/layout/MainLayout/Footer/index.js Outdated Show resolved Hide resolved
src/layout/MainLayout/Footer/index.js Outdated Show resolved Hide resolved
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
@CourtneyGosselin CourtneyGosselin merged commit fc7f2b7 into develop Feb 5, 2024
4 checks passed
@CourtneyGosselin CourtneyGosselin deleted the feature/footer branch February 5, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants