-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/footer #118
Feature/footer #118
Conversation
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled the branch and rebuilt stack. Looked at in Brave and Chrome - both chromium based browsers
A couple of minor bits of feedback:
-
When the summary page loads on my screen, the footer is out of sight of the main page as there is a large gap under the graphs.
-
Maybe we could reduce this spacing so that the footer shows at the bottom of the page. So minimum spacing would be about the same as the gap at the top with the header but when there is enough space it is anchored to the bottom of the screen.
Like:
-
Can we change the capitalisation of the funding statement to: "CanDIG receives funds from:" (sorry I pointed this out earlier on the shared screenshots)
-
Screenshots above don't show it but I played with the CANDIG_VERSION to see that it displays and it worked for me, not sure if it could be confusing about whether this is the version of the entire stack or the data portal itself.
-
Would be nice for the Candig version statement link to the relevant version of the stack? should be easy to add the given version to the url
https://github.com/CanDIG/CanDIGv2/releases/tag/v2.1.1
->https://github.com/CanDIG/CanDIGv2/releases/tag/${CANDIG_VERSION}
(however this is done in js that I have no clue about ) this means we do have to ensure the version is input into the .env file correctly when making stable releases to make sure the link isn't broken
Changed capilization and linking of versioning. Responsiveness bug moved to new JIRA ticket Signed-off-by: Courtney Gosselin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates! Happy to approve this from a visuals point of view (know nothing about the code so will leave that up to @OrdiNeu )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Signed-off-by: Courtney Gosselin <[email protected]>
Signed-off-by: Courtney Gosselin <[email protected]>
Ticket(s)
DIG-1350
Related PR
CanDIGv2 PR
Description
Addition of footer to all pages that is responsive to sizing. The footer should include:
Screenshots (if appropriate)
After PR
Types of Change(s)
Has it been tested for: