Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width and height issues #198

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Width and height issues #198

merged 4 commits into from
Dec 16, 2024

Conversation

CourtneyGosselin
Copy link
Member

Ticket(s)

DIG-1756: Search page sidebar too wide on sceens

Description

Adjust sidebar width for xl-lg for hamburger menu and kept blocking for mobile and tablet. This also fixes the height issue on the summary apge.

Screenshots

image
image

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots
  • Playwright test photos?

@mshadbolt
Copy link
Contributor

I think the sidebar looks good but looks like it is not actually filtering results anymore
Screenshot 2024-12-12 at 10 34 40 AM
Also at this resolution I used to have the graphs in one row, but now it is spread over two which I think is overkill, prefer to have the four graphs on one row

Copy link
Contributor

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the same issue that Marion does with the overly-large graphs on the search page.

@mshadbolt It looks as though you might've not clicked the search button after entering in your search terms (the search explainer at the top still says "All results")

Signed-off-by: Courtney Gosselin <[email protected]>
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
(Francis was totally right, I forgot to hit 'Search' )

@CourtneyGosselin CourtneyGosselin merged commit 6e68ee3 into develop Dec 16, 2024
3 checks passed
@CourtneyGosselin CourtneyGosselin deleted the bugfix/sidebar-width branch December 16, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants