-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an authentication check & page to request access #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d suggest a few minor visual changes. The shadow on the entire dialog is missing, as well as the shadow on the gray container, but these aren’t necessary if we prefer a flatter design. I’d change the pending hourglass to yellow, add 2–3em of spacing above the gray container and below the contact/request button, and adjust the hourglass padding to around 1em above and below. Also in the design the buttons were rounded to match other buttons across the site. Finally, the dialog box should be centered within the blue main container.
I also see some linter errors some which will resolve by merging in the develop branch
20a6792
to
63c8e06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just some minor linter warnings tested with user2
Ticket(s)
Description
Screenshots
To do/Tickets to be made before merging branch
Types of Change(s)
Has it been tested for: