Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an authentication check & page to request access #201

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Dec 18, 2024

Ticket(s)

Description

  • This allows a logged-in user to see a request access page if they are not yet in OPA, and to request access.

Screenshots

image

image

To do/Tickets to be made before merging branch

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu OrdiNeu changed the title Feature/auth page Add an authentication check & page to request access Dec 18, 2024
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d suggest a few minor visual changes. The shadow on the entire dialog is missing, as well as the shadow on the gray container, but these aren’t necessary if we prefer a flatter design. I’d change the pending hourglass to yellow, add 2–3em of spacing above the gray container and below the contact/request button, and adjust the hourglass padding to around 1em above and below. Also in the design the buttons were rounded to match other buttons across the site. Finally, the dialog box should be centered within the blue main container.

I also see some linter errors some which will resolve by merging in the develop branch
image

src/views/pages/authentication/AuthDisplay.js Outdated Show resolved Hide resolved
public/index.html Outdated Show resolved Hide resolved
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor linter warnings tested with user2

@OrdiNeu OrdiNeu merged commit 25ecb1b into develop Dec 19, 2024
3 checks passed
@OrdiNeu OrdiNeu deleted the feature/auth-page branch December 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants