DIG-1652: Remove use of OPA_SERVICE_TOKEN and OPA_ROOT_TOKEN #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using special tokens, we split up the use cases in these three ways:
v1/data/store_token
is the same as that internal secret.admin
. Those users can access any of Opa's paths.All previous tests that required passing in OPA_ROOT_TOKEN or OPA_SERVICE_TOKEN for the
X-Opa
header should now work correctly without that header, since they were one of the above use cases. Runmake clean-opa; make docker-volumes; make build-opa; make compose-opa
and then run integration tests. They should pass as before.