-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIG-1178: New AuthX model #9
base: develop
Are you sure you want to change the base?
Conversation
justin-ys
commented
May 31, 2023
•
edited
Loading
edited
- Adds is_permissible(request, dataset) method to validate individual requests
- Changes get_opa_datasets to get_readable_datasets
- Deprecates is_site_admin (still used internally until OPA update is ready)
- Backwards compatible, but warnings are provided for deprecated behavior
- Changes/appends tests appropriately
There was some discussion about refactoring the |
I think is_permissible won't accept a request object, since it's a new function anyway so nothing would be using it (except my branches, which have already moved to the new request model anyway). But this has been implemented for all other functions |
341e6cf
to
1664d2f
Compare
I am working on the OPA side now. We can't merge this until that's done, because the
Open to suggestions for a safer workaround that would let the rest of the data ingest project proceed. |