Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'single quote' in PR titles #43

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Replace 'single quote' in PR titles #43

merged 1 commit into from
Jun 17, 2024

Conversation

mshadbolt
Copy link
Contributor

  • Updating the dispatch action to allow PR titles with single quotes
    • replaces single quotes with double quotes in PR title
  • Change to using python to get the PR title and number and saves as env variables
  • Slight change to when it is being triggered, triggered by the merged pull request instead of the push to develop

This was needed because single quotes were causing the the dispatch action to fail as they are interpreted as a variable instead of just a string

@mshadbolt mshadbolt requested a review from OrdiNeu June 8, 2024 00:21
@mshadbolt mshadbolt merged commit f7878ba into develop Jun 17, 2024
@mshadbolt mshadbolt deleted the mshadbolt/fix-dispatch branch June 17, 2024 15:52
@candigbot candigbot mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrdiNeu OrdiNeu Awaiting requested review from OrdiNeu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mshadbolt