-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIG-1359: Documentation, error handling and code improvements for usability #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSVConvert will exit if it encounters a fatal error from its inputs OpenAPI schema is validated using openapi-spec-validator
Use proper csv reader to allow for quoted csvs to be read correctly
mshadbolt
commented
Nov 21, 2023
daisieh
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teeny code changes requested in CSVConvert. Otherwise, looks awesome and thank you so much for cleaning up all of our nonsense!
…m/CanDIG/clinical_ETL_code into mshadbolt/docs-and-error-handling
daisieh
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thanks!
mshadbolt
changed the title
Documentation, error handling and code improvements for usability
DIG-1359: Documentation, error handling and code improvements for usability
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
DIG-1343
DIG-1331
Summary of changes:
.gitignore
:CSVConvert.py
read_mapping_template()
so that quoted CSVs are read accuratelycheck_for_sheet_inconsistencies()
method to check that sheets identified in the mapping template are consistent with sheets given as input. (quick and dirty but not sure if best or most friendly way)generate_mapping_docs.py
mappings.py
and adds tomapping_functions.md
mapping_functions.md
generate_mapping_docs.py
mappings.py
schema.py
openapi-spec-validator
so it throws error if the spec is invalid.requirements.txt
sample_inputs
validate_coverage.py
Test and moh templates
indexed_on
errorsSome concerns/questions/ideas:
mappings.float()
overrides the inbuilt python method for casting as floatmappings.boolean()
defaults toTrue
if it doesn't match the listed options, this seems a little risky