Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change float() to floating() in mapping functions #54

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

lilyyangyi301
Copy link
Contributor

The previousfloat() function in mappings.py will cause confusion between the global float() function in python and the locally defined function since it's using the same name, and it was producing some errors. This fix will avoid this confusion.

Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilyyangyi301 lilyyangyi301 merged commit a9ba7c7 into develop Feb 29, 2024
2 checks passed
@lilyyangyi301 lilyyangyi301 deleted the lilyyang/fix_floating_mapping_function branch February 29, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants