Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index and minify command line arguments #55

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

mshadbolt
Copy link
Contributor

  • added a command line argument --index to enable the 'indexed' output json

    • For large datasets, the index file can get quite large and in a lot of contexts, is never looked at or used by a user.
    • default behaviour is to no longer output this file
  • added a command line argument --minify to enable 'minification' of jsons,

    • Removes white space and new lines to reduce the file size of the output
    • impacts human readability of the file so default behaviour is still to output, indented 'pretty' json

@mshadbolt mshadbolt requested a review from daisieh March 4, 2024 17:48
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I removed one space from a doc string.

src/clinical_etl/CSVConvert.py Outdated Show resolved Hide resolved
@mshadbolt mshadbolt merged commit 8a01ff9 into develop Mar 4, 2024
2 checks passed
@mshadbolt mshadbolt deleted the mshadbolt/json-minify branch March 4, 2024 21:27
@mshadbolt mshadbolt restored the mshadbolt/json-minify branch March 4, 2024 21:28
mshadbolt added a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants