Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix int method, more details in warning #58

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix int method, more details in warning #58

merged 1 commit into from
Mar 6, 2024

Conversation

mshadbolt
Copy link
Contributor

  • Fixed the mappings.integer() method so that it works with decimal strings
    • added a few of decimal strings to the test file to show it works
  • Added input data to the warning so that it provides more information to a user trying to correct validation errors

@mshadbolt mshadbolt requested a review from daisieh March 6, 2024 21:24
daisieh
daisieh approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@mshadbolt mshadbolt merged commit b3b4816 into develop Mar 6, 2024
2 checks passed
@mshadbolt mshadbolt deleted the mshadbolt/fix-int-method branch March 6, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daisieh daisieh daisieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshadbolt @daisieh