Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIG-1819: Warn instead of error when reference date missing & add validation to required fields #86

Merged
merged 10 commits into from
Nov 8, 2024
Merged

DIG-1819: Warn instead of error when reference date missing & add validation to required fields #86

merged 10 commits into from
Nov 8, 2024
+117 −53

Conversation

mshadbolt
Copy link
Contributor

No description provided.

@yavyx yavyx changed the title DIG-1819: Warn instead of error when reference date missing DIG-1819: Warn instead of error when reference date missing & add validation to required fields Nov 8, 2024
@yavyx
Copy link
Contributor

yavyx commented Nov 8, 2024

The scope of this PR increased after checking why warnings weren't thrown when required dates are missing.

Changes:

  • Print a warning when the reference date is missing, instead of exiting the program @mshadbolt
  • Validate all unconditionally required fields and add warnings to _validation_results.json
  • Update and improve the relevant tests

@yavyx yavyx marked this pull request as ready for review November 8, 2024 01:14
@yavyx yavyx requested a review from daisieh November 8, 2024 01:14
daisieh
daisieh approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I didn't test.

@mshadbolt
Copy link
Contributor Author

LGTM will merge

@mshadbolt mshadbolt merged commit b57146f into develop Nov 8, 2024
1 check passed
@mshadbolt mshadbolt deleted the mshadbolt/reference-date-warnings branch November 8, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daisieh daisieh daisieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshadbolt @yavyx @daisieh